Skip to content

Make std::fs::File Send on UEFI#154003

Open
ginnyTheCat wants to merge 1 commit intorust-lang:mainfrom
ginnyTheCat:uefi-file-send
Open

Make std::fs::File Send on UEFI#154003
ginnyTheCat wants to merge 1 commit intorust-lang:mainfrom
ginnyTheCat:uefi-file-send

Conversation

@ginnyTheCat
Copy link
Contributor

@ginnyTheCat ginnyTheCat commented Mar 17, 2026

Similarly to #150990 since UEFI has no threads, this should be safe.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 17, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, joboet

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Mar 23, 2026

Hm, I'm wondering if this justification is really enough. If it is, it seems like this is something we should teach the compiler about, rather than putting it in code where it might be left in by accident / copied into the wrong place / etc. I'll start a thread on Zulip about that (edit: https://rust-lang.zulipchat.com/#narrow/channel/136281-t-opsem/topic/Send.20on.20thread-free.20targets/with/580986733).

I guess this is technically also making a new stable guarantee (although on a tier 2 target), so it probably needs FCP? I see that wasn't applied in #150990, perhaps because it seems like this is 'obvious', but it seems like we should at least raise it with libs-api.

@Mark-Simulacrum Mark-Simulacrum added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Mar 23, 2026
@Mark-Simulacrum
Copy link
Member

Also, can you say a bit more about the rationale for this? What specifically is needing a Send bound that's making this needed on the target? I see the other PR mentions remote-test-server, but I'm not seeing any merged PRs there recently that seem related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I-libs-api-nominated Nominated for discussion during a libs-api team meeting. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants