Skip to content

unstable impl of From<{i64, u64}> for f128#154012

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
folkertdev:f128-from-instances
Mar 18, 2026
Merged

unstable impl of From<{i64, u64}> for f128#154012
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
folkertdev:f128-from-instances

Conversation

@folkertdev
Copy link
Contributor

@folkertdev folkertdev commented Mar 17, 2026

r? tgross35

@folkertdev folkertdev added the F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` label Mar 17, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 17, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2026

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

tgross35
tgross35 approved these changes Mar 17, 2026
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with passing CI

View changes since this review

@folkertdev
Copy link
Contributor Author

folkertdev commented Mar 17, 2026

@bors r=tgross35 rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 17, 2026

📌 Commit 681b48e has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 17, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 17, 2026
@bors
Auto merge of #154013 - JonathanBrouwer:rollup-J4887ML, r=JonathanBro…
91775db 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #152998 (std: make `OsString::truncate` a no-op when `len > current_len`)
 - #153682 (Tweak E0599 note)
 - #153795 (Point turbofish inference errors at the uninferred generic arg)
 - #153994 (move `tests/ui/invalid` tests to new folders)
 - #154006 (attrs: Ignore ExprKind::Err when converting path attr expr to lit)
 - #154012 (unstable impl of `From<{i64, u64}> for f128`)
@rust-bors rust-bors bot merged commit eb61706 into rust-lang:main Mar 18, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels

F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

3 participants

@folkertdev @rustbot @tgross35