Skip to content

Stabilize fN::BITS#154065

Open
Apersoma wants to merge 2 commits intorust-lang:mainfrom
Apersoma:stabilize-fN-bits
Open

Stabilize fN::BITS#154065
Apersoma wants to merge 2 commits intorust-lang:mainfrom
Apersoma:stabilize-fN-bits

Conversation

@Apersoma
Copy link

@Apersoma Apersoma commented Mar 19, 2026

Tracking issue: #151073
Closes: #151073

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 19, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 19, 2026

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, scottmcm

@rustbot
Copy link
Collaborator

rustbot commented Mar 19, 2026

compiler-builtins is developed in its own repository. If possible, consider making this change to rust-lang/compiler-builtins instead.

cc @tgross35

@rustbot rustbot added the A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) label Mar 19, 2026
@tgross35 tgross35 assigned tgross35 and unassigned scottmcm Mar 19, 2026
@tgross35
Copy link
Contributor

This has only been around since January but it seems pretty unobjectionable to have. However, this does conflict with a constant in use in the ecosystem (showed up in the implementation PR) so we need to take a look at crater.

@bors try

@rustbot label +I-libs-api-nominated

@rustbot rustbot added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Mar 19, 2026
@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Mar 19, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 19, 2026

☀️ Try build successful (CI)
Build commit: 0abe69e (0abe69e6c16114311cc2700e972492e64d69c28f, parent: 1f7f8ea0721a3b1eb73e6c6d25cccb371434b320)

@tgross35
Copy link
Contributor

Doing a run with tests in case somebody has a different value for BITS for some reason.

@craterbot run mode=build-and-test

@craterbot
Copy link
Collaborator

👌 Experiment pr-154065 created and queued.
🤖 Automatically detected try build 0abe69e
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) I-libs-api-nominated Nominated for discussion during a libs-api team meeting. S-waiting-on-crater Status: Waiting on a crater run to be completed. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking Issue for fN::BITS

5 participants