ui/lto: move and rename two tests from issues/ by ujjwalvishwakarma2006 · Pull Request #154167 · rust-lang/rust

ujjwalvishwakarma2006 · 2026-03-21T11:10:34Z

Move:

tests/ui/issues/issue-44056.rs -> tests/ui/lto/lto-avx-target-feature.rs
- The first test enables both AVX target features and LTO but does not exercise AVX-specific behavior. The test primarily checks that LTO builds successfully with these flags; place it under ui/lto for consistency.
tests/ui/issues/issue-51947.rs -> tests/ui/lto/lto-weak-merge-functions.rs
- The second test exercises weak linkage interacting with LTO (merge-functions), so it should belong in ui/lto.

I have also added a commented line at the top of each test file indicating the issue it originated from.

zedddie · 2026-03-21T16:42:09Z

hey! usually you'd split these into separate commits (check this discussion) and add a comment at the top referencing the original issue, something like //! regression test for <https://github.com/rust-lang/rust/issues/XXXXX>.

ujjwalvishwakarma2006 · 2026-03-21T17:20:06Z

@zedddie Oh. Sorry, I wasn't aware of this. I thought I should consolidate as many files as possible into a single commit so that they don't clutter commits that actually fix some bugs or add features.

Also, isn't it inefficient? Because after every commit, the "internal tool" runs some checks, and it takes about an hour to execute those checks.

BTW, I have made changes in the top comment.

zedddie · 2026-03-21T17:40:46Z

Oh. Sorry, I wasn't aware of this

It's totally fine! You aren't supposed to know everything beforehand.

Also, isn't it inefficient? Because after every commit, the "internal tool" runs some checks, and it takes about an hour to execute those checks.

I believe the tidy check should run as pre-push hook, not after each commit. I can suggest you looking at this chapter of rustc-dev-guide for more info!

zedddie · 2026-03-21T17:47:53Z

BTW, I have made changes in the top comment.

Oops maybe what I said wasn't really clear, I meant adding this lines to the top of the renamed test files.
So for example test tests/ui/issues/issue-44056, after renaming would loss metadata about the issue it originates from, so you should add the line at the top of a test file:

//! regression test for <https://github.com/rust-lang/rust/issues/44056>
//@ build-pass (FIXME(55996): should be run on targets supporting avx)
//@ only-x86_64
//@ no-prefer-dynamic
//@ compile-flags: -Ctarget-feature=+avx -Clto
//@ ignore-backends: gcc

fn main() {}

not PR description.
You can check this PR to have a picture of how workflow is done usually.

…s/ui/lto/

ujjwalvishwakarma2006 · 2026-03-21T19:26:14Z

@zedddie
I have made the changes following the steps mentioned in the discussion. Kindly review.

Kivooeo · 2026-03-21T19:54:45Z

FYI: We're discouraging using Copilot for reviews. Once IT completes its review, Copilot-generated messages will be hidden as spam.

ujjwalvishwakarma2006 · 2026-03-21T20:01:08Z

FYI: We're discouraging using Copilot for reviews. Once IT completes its review, Copilot-generated messages will be hidden as spam.

I don't know why the Copilot review started automatically. Who is responsible for changing this functionality - the contributor or the organization? Do I need to disable the Copilot reviewer?

If yes, let me fix this in future commits.

Edit: I got the answer, it's in my hands ( :

Kivooeo · 2026-03-21T20:04:20Z

Yep, this should be in your settings -- we've already disabled automatic Copilot reviews.

Kivooeo · 2026-03-21T22:52:03Z

Can you squash the third commit into the second, and we should be good to go.

Thanks, @zedddie, for helping out here!

…riginate from

Kivooeo · 2026-03-22T18:52:08Z

@bors r+ rollup

rust-bors · 2026-03-22T18:52:12Z

📌 Commit dd2b208 has been approved by Kivooeo

It is now in the queue for this repository.

…ts, r=Kivooeo ui/lto: move and rename two tests from issues/ Move: - `tests/ui/issues/issue-44056.rs` -> `tests/ui/lto/lto-avx-target-feature.rs` - The first test enables both AVX target features and LTO but does not exercise AVX-specific behavior. The test primarily checks that LTO builds successfully with these flags; place it under `ui/lto` for consistency. - `tests/ui/issues/issue-51947.rs` -> `tests/ui/lto/lto-weak-merge-functions.rs` - The second test exercises weak linkage interacting with LTO (merge-functions), so it should belong in `ui/lto`. I have also added a commented line at the top of each test file indicating the issue it originated from.

…uwer Rollup of 22 pull requests Successful merges: - #122668 (Add APIs for dealing with titlecase) - #152543 (privacy: Fix type privacy holes in RPITITs) - #153107 (Optimize BTreeMap::append() using CursorMut) - #153312 (Packages as namespaces part 1) - #153534 (Remove a flaky `got_timeout` assert from two channel tests) - #153718 (Fix environ on FreeBSD with cdylib targets that use -Wl,--no-undefined .) - #153857 (Rename `target.abi` to `target.cfg_abi` and enum-ify llvm_abiname) - #153880 (Lifted intersperse and intersperse_with Fused transformation and updated documentation + tests) - #153931 (remove usages of to-be-deprecated numeric constants) - #150630 (Unknown -> Unsupported compression algorithm) - #153491 (Move `freeze_*` methods to `OpenOptionsExt2`) - #153582 (Simplify find_attr! for HirId usage) - #153623 (std: move `sys::pal::os` to `sys::paths`) - #153647 (docs(fs): Clarify That File::lock Coordinates Across Processes) - #153936 (Skip stack_start_aligned for immediate-abort) - #154011 (implement `BinaryHeap::as_mut_slice`) - #154167 (ui/lto: move and rename two tests from issues/) - #154174 (allow `incomplete_features` in most UI tests) - #154175 (Add new alias for Guillaume Gomez email address) - #154182 (diagnostics: avoid ICE for undeclared generic parameter in impl) - #154188 (Update the tracking issue for #[diagnostic::on_move]) - #154201 (Use enums to clarify `DepNodeColorMap` color marking )

…uwer Rollup of 21 pull requests Successful merges: - #152543 (privacy: Fix type privacy holes in RPITITs) - #153107 (Optimize BTreeMap::append() using CursorMut) - #153312 (Packages as namespaces part 1) - #153534 (Remove a flaky `got_timeout` assert from two channel tests) - #153718 (Fix environ on FreeBSD with cdylib targets that use -Wl,--no-undefined .) - #153857 (Rename `target.abi` to `target.cfg_abi` and enum-ify llvm_abiname) - #153880 (Lifted intersperse and intersperse_with Fused transformation and updated documentation + tests) - #153931 (remove usages of to-be-deprecated numeric constants) - #150630 (Unknown -> Unsupported compression algorithm) - #153491 (Move `freeze_*` methods to `OpenOptionsExt2`) - #153582 (Simplify find_attr! for HirId usage) - #153623 (std: move `sys::pal::os` to `sys::paths`) - #153647 (docs(fs): Clarify That File::lock Coordinates Across Processes) - #153936 (Skip stack_start_aligned for immediate-abort) - #154011 (implement `BinaryHeap::as_mut_slice`) - #154167 (ui/lto: move and rename two tests from issues/) - #154174 (allow `incomplete_features` in most UI tests) - #154175 (Add new alias for Guillaume Gomez email address) - #154182 (diagnostics: avoid ICE for undeclared generic parameter in impl) - #154188 (Update the tracking issue for #[diagnostic::on_move]) - #154201 (Use enums to clarify `DepNodeColorMap` color marking )

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 21, 2026

Kivooeo self-assigned this Mar 21, 2026

Move and rename LTO-specific test files from tests/ui/issues/ to test…

9b7dff9

…s/ui/lto/

ujjwalvishwakarma2006 force-pushed the move-lto-tests branch from 9b8d21b to f8676e7 Compare March 21, 2026 18:53

ujjwalvishwakarma2006 marked this pull request as ready for review March 21, 2026 19:48

Copilot AI review requested due to automatic review settings March 21, 2026 19:48

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 21, 2026

Copilot started reviewing on behalf of ujjwalvishwakarma2006 March 21, 2026 19:49 View session

This comment was marked as spam.

Sign in to view

ujjwalvishwakarma2006 force-pushed the move-lto-tests branch from f8676e7 to f10cd0e Compare March 22, 2026 04:52

Add comment at the top in two test files referencing the issue they o…

dd2b208

…riginate from

ujjwalvishwakarma2006 force-pushed the move-lto-tests branch from f10cd0e to dd2b208 Compare March 22, 2026 09:49

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2026

JonathanBrouwer mentioned this pull request Mar 22, 2026

Rollup of 10 pull requests #154222

Closed

JonathanBrouwer mentioned this pull request Mar 22, 2026

Rollup of 23 pull requests #154226

Closed

JonathanBrouwer mentioned this pull request Mar 22, 2026

Rollup of 22 pull requests #154227

Closed

JonathanBrouwer mentioned this pull request Mar 23, 2026

Rollup of 21 pull requests #154255

Merged

rust-bors bot merged commit 364844d into rust-lang:main Mar 23, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Mar 23, 2026

Uh oh!

Conversation

ujjwalvishwakarma2006 commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zedddie commented Mar 21, 2026

Uh oh!

ujjwalvishwakarma2006 commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zedddie commented Mar 21, 2026

Uh oh!

zedddie commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ujjwalvishwakarma2006 commented Mar 21, 2026

Uh oh!

This comment was marked as spam.

Uh oh!

Kivooeo commented Mar 21, 2026

Uh oh!

ujjwalvishwakarma2006 commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kivooeo commented Mar 21, 2026

Uh oh!

Kivooeo commented Mar 21, 2026

Uh oh!

Kivooeo commented Mar 22, 2026

Uh oh!

rust-bors bot commented Mar 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ujjwalvishwakarma2006 commented Mar 21, 2026 •

edited

Loading

ujjwalvishwakarma2006 commented Mar 21, 2026 •

edited

Loading

zedddie commented Mar 21, 2026 •

edited

Loading

ujjwalvishwakarma2006 commented Mar 21, 2026 •

edited

Loading