Merged
Conversation
This is very half-baked at the moment and very inefficient, e.g. inappropriate use of by-value `self` (and thus being forced into an overuse of `clone`). People get the wrong impression about Rust when using it, e.g. that Rust cannot express what other languages can because the implementation is inefficient.
Contributor
|
Are those the only flaws with the implementation? I'd like to know any known issues for possible future fixes. |
Contributor
Author
|
They are the two major flaws, but I haven't looked in detail. |
bors
added a commit
that referenced
this pull request
Aug 17, 2014
This is very half-baked at the moment and very inefficient, e.g. inappropriate use of by-value `self` (and thus being forced into an overuse of `clone`). People get the wrong impression about Rust when using it, e.g. that Rust cannot express what other languages can because the implementation is inefficient: https://news.ycombinator.com/item?id=8187831 .
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 12, 2026
Replace typo'd name with link to the referenced lint. changelog: none
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Mar 22, 2026
``` $ git log --oneline 85eff7c80277b57f78b11e28d14154ab12fcf643..292f395c297d4f99171325b0842ac4ea4ff3b386 292f395c2 (HEAD) [stable 1.94] Fix symlink_and_directory when running in a long target dir name (rust-lang#16777) d00475981 Fix symlink_and_directory when running in a long target dir name (rust-lang#16775) ce98781f7 [stable 1.94] Update tar to 0.4.45 (rust-lang#16769) fec7f9297 Update tar to 0.4.45 5e256e377 Add a test for a tar file with a symlink and directory of the same name 1ed92053d test: Remove unused docker ip_address (rust-lang#16636) d7a2a0307 Increase cache_lock test timeout (rust-lang#16545) 95d93fb89 Don't check the specific build-std output dfbe729f6 chore: Updated compiler errors for Rust 1.93 (rust-lang#16543) cb03b21f6 Update cargo-semver-checks to 0.47.0 f7777c4f9 test(build-std): Update error message (rust-lang#16658) a56abe18a Disable custom target JSON spec test 634668d49 fix: `--remap-path-scope` stabilized in 1.95-nightly (rust-lang#16536) d428eaa44 fix(script): surpress `unused_features` lint for embedded (rust-lang#16714) e7b27c7f9 test(git): Mark a test as non-deterministic (rust-lang#16706) 38922ca44 test(replace): Mark a test as non-deterministic (rust-lang#16700) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very half-baked at the moment and very inefficient, e.g.
inappropriate use of by-value
self(and thus being forced into anoveruse of
clone). People get the wrong impression about Rust whenusing it, e.g. that Rust cannot express what other languages can because
the implementation is inefficient: https://news.ycombinator.com/item?id=8187831 .