Add support for --bindir and remember the relative locations of bindir and libdir vs prefix (ie: sysroot)#19065
Closed
codyps wants to merge 9 commits intorust-lang:masterfrom
Closed
Add support for --bindir and remember the relative locations of bindir and libdir vs prefix (ie: sysroot)#19065codyps wants to merge 9 commits intorust-lang:masterfrom
codyps wants to merge 9 commits intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential downsides:
realpath, which I'm not sure everyone has, to determine relative directories. It's possible we could substitute something else if this matters.Upsides:
--libdirnow avoids breaking things at runtime if it isn't in one of the expected locations