Feature gate macro arguments #20190
Feature gate macro arguments #20190
Conversation
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
src/libsyntax/feature_gate.rs
Outdated
There was a problem hiding this comment.
Instead of being a macro like this (and requiring it to be before all checks), could this just move into the gate_feature function?
|
Thanks! Could you add some more tests as well for things like using a feature in a macro, but not having it as part of an argument? Also, to close #18102 I think this needs test cases along the lines of:
|
|
@alexcrichton macro definitions are part of #12122 which I planned on fixing in a follow-up PR. This PR doesn't do anything for macros which internally used gated features. |
|
(And I plan on fixing #12122 by erroring on macro definition, rather than unsuspecting user code) |
src/libsyntax/feature_gate.rs
Outdated
There was a problem hiding this comment.
This change may be ok to undo, we tend to prefer braces around multi-line arms.
|
Awesome, thanks @cmr! Just a few minor nits and otherwise r=me |
Uses the same approach as #17286 (and subsequent changes making it more correct), where the visitor will skip any pieces of the AST that are from "foreign code", where the spans don't line up, indicating that that piece of code is due to a macro expansion. If this breaks your code, read the error message to determine which feature gate you should add to your crate, and bask in the knowledge that your code won't mysteriously break should you try to use the 1.0 release. Closes #18102 [breaking-change]
Uses the same approach as #17286 (and subsequent changes making it more correct), where the visitor will skip any pieces of the AST that are from "foreign code", where the spans don't line up, indicating that that piece of code is due to a macro expansion. If this breaks your code, read the error message to determine which feature gate you should add to your crate. Closes #18102 [breaking-change]
5 participants
Uses the same approach as #17286 (and
subsequent changes making it more correct), where the visitor will skip any
pieces of the AST that are from "foreign code", where the spans don't line up,
indicating that that piece of code is due to a macro expansion.
If this breaks your code, read the error message to determine which feature
gate you should add to your crate.
Closes #18102
[breaking-change]