Permit node types to be missing if type errors occurred previously #20897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
r? @nick29581 (rust_highfive has picked a reviewer for you, use r? to override) |
barosl
force-pushed
the
no-type-for-node-ice
branch
from
67b3dab to
7b6f52a
Compare
If the type of a node cannot be determined due to a previous type error, a "no type for node" ICE occurs. This commit makes it return ty_err instead in such a case. Fixes rust-lang#20401. Fixes rust-lang#20506. Fixes rust-lang#20614. Fixes rust-lang#20752. Fixes rust-lang#20829. Fixes rust-lang#20846. Fixes rust-lang#20885. Fixes rust-lang#20886.
barosl
force-pushed
the
no-type-for-node-ice
branch
from
7b6f52a to
a015544
Compare
bors
added a commit
that referenced
this pull request
Jan 12, 2015
If the type of a node cannot be determined due to a previous type error, a `no type for node` ICE occurs. This commit makes it return `ty_err` instead in such a case. Fixes #20401. Fixes #20506. Fixes #20614. Fixes #20752. Fixes #20829. Fixes #20846. Fixes #20885. Fixes #20886. Fixes #20952. Fixes #20970.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the type of a node cannot be determined due to a previous type error, a
no type for nodeICE occurs. This commit makes it returnty_errinstead in such a case.Fixes #20401.
Fixes #20506.
Fixes #20614.
Fixes #20752.
Fixes #20829.
Fixes #20846.
Fixes #20885.
Fixes #20886.
Fixes #20952.
Fixes #20970.