impl Iterator for &mut Iterator and Box<Iterator>#21392
Merged
bors merged 2 commits intorust-lang:masterfrom Jan 22, 2015
Merged
impl Iterator for &mut Iterator and Box<Iterator>#21392bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
Member
|
😍 |
Contributor
|
Is there not a better place to put these tests than a run-pass? Where we test boxes? Or iterators? |
Member
|
@bors: r+ 74e111c We may be able to put them in one of the core libraries, but it tends to be easier to test "under std" modules in run-pass (due to prelude weirdness) |
Contributor
|
|
Contributor
Author
|
@Kroisse yes, you are right. Done. |
Member
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 21, 2015
closes rust-lang#20953 closes rust-lang#21361 --- In the future, we will likely derive these `impl`s via syntax extensions or using compiler magic (see rust-lang#20617). For the time being we can use these manual `impl`s. r? @aturon cc @BurntSushi @Kroisse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #20953
closes #21361
In the future, we will likely derive these
impls via syntax extensions or using compiler magic (see #20617). For the time being we can use these manualimpls.r? @aturon
cc @BurntSushi @Kroisse