Skip to content

std: Remove extra type params on iter adaptors#21842

Merged
bors merged 1 commit intorust-lang:masterfrom
alexcrichton:issue-21839
Feb 3, 2015
Merged

std: Remove extra type params on iter adaptors#21842
bors merged 1 commit intorust-lang:masterfrom
alexcrichton:issue-21839

Conversation

@alexcrichton
Copy link
Member

Now that associated types are fully implemented the iterator adaptors only need
type parameters which are associated with actual storage. All other type
parameters can either be derived from these (e.g. they are an associated type)
or can be bare on the impl block itself.

This is a breaking change due to the removal of type parameters on these
iterator adaptors, but code can fairly easily migrate by just deleting the
relevant type parameters for each adaptor. Other behavior should not be
affected.

Closes #21839
[breaking-change]

Now that associated types are fully implemented the iterator adaptors only need
type parameters which are associated with actual storage. All other type
parameters can either be derived from these (e.g. they are an associated type)
or can be bare on the `impl` block itself.

This is a breaking change due to the removal of type parameters on these
iterator adaptors, but code can fairly easily migrate by just deleting the
relevant type parameters for each adaptor. Other behavior should not be
affected.

Closes rust-lang#21839
[breaking-change]
@rust-highfive
Copy link
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned pcwalton Feb 1, 2015
@aturon
Copy link
Contributor

aturon commented Feb 1, 2015

Nice!

@bors: r+ 0e44484

@bluss
Copy link
Contributor

bluss commented Feb 1, 2015

Love this change to Map!

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 2, 2015
 Now that associated types are fully implemented the iterator adaptors only need
type parameters which are associated with actual storage. All other type
parameters can either be derived from these (e.g. they are an associated type)
or can be bare on the `impl` block itself.

This is a breaking change due to the removal of type parameters on these
iterator adaptors, but code can fairly easily migrate by just deleting the
relevant type parameters for each adaptor. Other behavior should not be
affected.

Closes rust-lang#21839
[breaking-change]
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Feb 2, 2015
Now that associated types are fully implemented the iterator adaptors only need
type parameters which are associated with actual storage. All other type
parameters can either be derived from these (e.g. they are an associated type)
or can be bare on the `impl` block itself.

This is a breaking change due to the removal of type parameters on these
iterator adaptors, but code can fairly easily migrate by just deleting the
relevant type parameters for each adaptor. Other behavior should not be
affected.

Closes rust-lang#21839
[breaking-change]
@bors bors merged commit 0e44484 into rust-lang:master Feb 3, 2015
@alexcrichton alexcrichton deleted the issue-21839 branch February 4, 2015 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple *stable* iterator adaptors have useless type parameters

6 participants