Improve documentation for libcollections/str #22513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
r=me |
steveklabnik
force-pushed
the
doc_str
branch
from
3350a13 to
27f3571
Compare
Contributor
Author
|
@brson, seems legit. change made |
Contributor
Author
bombless
added a commit
to bombless/rust
that referenced
this pull request
Feb 23, 2015
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 23, 2015
Contributor
|
why were all the tags removed? now https://github.com/rust-lang/rust/pull/22513/files#diff-2544e5e5ce71797344d5ec6acde08b87R1074 is an invalid example, and I thought the doc tests were made to catch that. (patch for that particular one incoming) |
Contributor
Author
|
Because it defaults to Rust, and so there's no need to annotate it. Current style is to use the annotation in long form docs (so it renders on github) and not use it in API docs (because it is redundant) |
Contributor
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.