Skip to content

configure: Don't succeed if valgrind isn't available. Fixes #18588 #24477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson wants to merge 2 commits into from
Closed

configure: Don't succeed if valgrind isn't available. Fixes #18588 #24477

brson wants to merge 2 commits into from

Conversation

@brson
Copy link
Contributor

@brson brson commented Apr 15, 2015

Based on @emanueLczirai's patch.

r? @nrc

apasel422
apasel422 reviewed Apr 15, 2015
View reviewed changes
configure Outdated
Copy link
Contributor

@apasel422 apasel422 Apr 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/it's/its/

@nrc
Copy link
Member

nrc commented Apr 15, 2015

r+, I guess with the typo fixed

@brson
Copy link
Contributor Author

brson commented Apr 22, 2015

@bors r=nrc rollup

@bors
Copy link
Collaborator

bors commented Apr 22, 2015

📌 Commit 31856a5 has been approved by nrc

@Manishearth
Copy link
Member

Manishearth commented Apr 23, 2015

Can valgrind be disabled by default in the configure? IMO ./configure should generally just work on common systems, and valgrind is usually not there out of the box.

@bors
Copy link
Collaborator

bors commented Apr 23, 2015

⌛ Testing commit 31856a5 with merge e75d39d...

@bors
Copy link
Collaborator

bors commented Apr 23, 2015

💔 Test failed - auto-win-64-nopt-t

@Manishearth
Copy link
Member

Manishearth commented Apr 24, 2015 

configure: error: valgrind not found, but needed. consider adding --disable-valgrind-rpass
program finished with exit code 1
elapsedTime=2.558000

@ghost
Copy link

ghost commented Apr 24, 2015

One thing to note is that --disable-valgrind doesn't imply --disable-valgrind-rpass as far as I remember. It seemed to me, it was intended this way from the beginning.
The relevant "discussion" is here: #18588 (comment)

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 24, 2015
@steveklabnik
Rollup merge of rust-lang#24477 - brson:valgrindconfig, r=nrc
0378f29 
Based on @emanueLczirai's patch.

r? @nrc
@steveklabnik steveklabnik mentioned this pull request Apr 24, 2015
Closed
@steveklabnik
Copy link
Contributor

steveklabnik commented Apr 24, 2015

@bors: r-

@brson brson mentioned this pull request Apr 28, 2015
Merged
@steveklabnik
Copy link
Contributor

steveklabnik commented May 15, 2015

@brson: now that #24859 is merged, is this PR needed?

@brson
Copy link
Contributor Author

brson commented Jun 12, 2015

I think it is not.

@brson brson closed this Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nrc nrc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@brson @nrc @bors @Manishearth @steveklabnik @apasel422