Skip to content

fix doc #24837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FuGangqiang wants to merge 7 commits into from
Closed

fix doc #24837

FuGangqiang wants to merge 7 commits into from

Conversation

@FuGangqiang
Copy link
Contributor

@FuGangqiang FuGangqiang commented Apr 26, 2015

No description provided.

@rust-highfive
Copy link
Contributor

rust-highfive commented Apr 26, 2015

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

steveklabnik
steveklabnik reviewed Apr 26, 2015
View reviewed changes
src/doc/trpl/generics.md Outdated
Copy link
Contributor

@steveklabnik steveklabnik Apr 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commas go inside of double quotes, actually.

Copy link
Contributor Author

@FuGangqiang FuGangqiang Apr 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for that, my english is not very good,maybe I'm wrong.

pnkfelix
pnkfelix reviewed Apr 30, 2015
View reviewed changes
src/doc/trpl/enums.md Outdated
Copy link
Contributor

@pnkfelix pnkfelix Apr 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you delete the space between a and 'sum type' here?

Copy link
Contributor Author

@FuGangqiang FuGangqiang Apr 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en,they shouldn't be deleted as well as others, I will turn it back!

@bors
Copy link
Collaborator

bors commented May 8, 2015

☔ The latest upstream changes (presumably #25218) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented May 13, 2015

☔ The latest upstream changes (presumably #25357) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented May 17, 2015

☔ The latest upstream changes (presumably #25525) made this pull request unmergeable. Please resolve the merge conflicts.

@FuGangqiang FuGangqiang deleted the doc branch May 17, 2015 13:04
@FuGangqiang
Copy link
Contributor Author

FuGangqiang commented May 17, 2015

the doc has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pcwalton pcwalton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@FuGangqiang @rust-highfive @bors @steveklabnik @pnkfelix @pcwalton