Skip to content

Conversation

@swaroopch
Copy link
Contributor

I don't recall reading about this Debug trait so far in the book. Please ignore this PR if I have missed that part.

r? @steveklabnik

I don't recall reading about this `Debug` trait so far in the book.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Contributor

Thanks @swaroopch ! I want to make a chapter specifically about display and debug, but until then, this is an improvement for sure. Thanks!

@steveklabnik
Copy link
Contributor

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented May 13, 2015

📌 Commit baef132 has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request May 13, 2015
I don't recall reading about this `Debug` trait so far in the book. Please ignore this PR if I have missed that part.

r? @steveklabnik
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "lets", not "let's", right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, and it probably should be to std, not core.

@swaroopch , up for a second PR after this one lands? heh. It's already being tested in the rollup, or i'd say fix it first

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfackler @steveklabnik I added a second commit to same branch in my fork - f6e5369 - but I'm a bit confused on how this works - should I do a separate PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! so, #25377 failed. so no, you don't need to make a new PR

@steveklabnik
Copy link
Contributor

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented May 13, 2015

📌 Commit f6e5369 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 13, 2015
I don't recall reading about this `Debug` trait so far in the book. Please ignore this PR if I have missed that part.

r? @steveklabnik
bors added a commit that referenced this pull request May 13, 2015
@bors bors merged commit f6e5369 into rust-lang:master May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants