Skip to content

Add E0092, E0093, E0094, E0101, E0117, E0119, E0195, E0207 and E0211 error explanation #26651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 9 commits into from
Jul 1, 2015
Merged

Add E0092, E0093, E0094, E0101, E0117, E0119, E0195, E0207 and E0211 error explanation #26651

bors merged 9 commits into from
Jul 1, 2015

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jun 29, 2015

nagisa
nagisa reviewed Jun 29, 2015
View reviewed changes
src/librustc_typeck/diagnostics.rs Outdated
Copy link
Member

@nagisa nagisa Jun 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the comment could go to the next line (or get deindented on the second line) instead of wrapping and spanning 4 whole lines?

Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Jun 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw it like this in other error explanations. So I don't mind. I'll wait for other opinions before changing it, we'll see what people say.

Copy link
Member

@Manishearth Manishearth Jun 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer having it on the next line

@GuillaumeGomez GuillaumeGomez changed the title Add E0195 error explanation Add E0093, E0094, E0195 and E0211 error explanation Jun 30, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0093, E0094, E0195 and E0211 error explanation Add E0092, E0093, E0094, E0195 and E0211 error explanation Jun 30, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0092, E0093, E0094, E0195 and E0211 error explanation Add E0092, E0093, E0094, E0101, E0195 and E0211 error explanation Jun 30, 2015
Manishearth
Manishearth reviewed Jun 30, 2015
View reviewed changes
src/librustc_typeck/diagnostics.rs Outdated
Copy link
Member

@Manishearth Manishearth Jun 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"tried to declare"

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jun 30, 2015

@Manishearth: Updated! Do you see anything else ?

Manishearth
Manishearth reviewed Jun 30, 2015
View reviewed changes
src/librustc_typeck/diagnostics.rs Outdated
Copy link
Member

@Manishearth Manishearth Jun 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Backticks around 'b
  • "The lifetime constraint 'b for the implementation of t() does not match the trait declaration"
  • replacing t with method might be better

@Manishearth
Copy link
Member

Manishearth commented Jun 30, 2015

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 30, 2015

📌 Commit 5aeecd2 has been approved by Manishearth

@Manishearth
Copy link
Member

Manishearth commented Jun 30, 2015

@bors r-

@Manishearth
Copy link
Member

Manishearth commented Jun 30, 2015

Still missing #26651 (diff)

@GuillaumeGomez GuillaumeGomez changed the title Add E0092, E0093, E0094, E0101, E0195 and E0211 error explanation Add E0092, E0093, E0094, E0101, E0121, E0195 and E0211 error explanation Jun 30, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0092, E0093, E0094, E0101, E0121, E0195 and E0211 error explanation Add E0092, E0093, E0094, E0101, E0117, E0195 and E0211 error explanation Jun 30, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0092, E0093, E0094, E0101, E0117, E0195 and E0211 error explanation Add E0092, E0093, E0094, E0101, E0117, E0195, E0207 and E0211 error explanation Jun 30, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0092, E0093, E0094, E0101, E0117, E0195, E0207 and E0211 error explanation Add E0092, E0093, E0094, E0101, E0117, E0119, E0195, E0207 and E0211 error explanation Jun 30, 2015
nagisa
nagisa reviewed Jun 30, 2015
View reviewed changes
src/librustc_typeck/diagnostics.rs
Copy link
Member

@nagisa nagisa Jun 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this function to exist in order to reproduce the error?

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jun 30, 2015

Anything else to fix/change ?

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jun 30, 2015

Squashed.

@Manishearth
Copy link
Member

Manishearth commented Jun 30, 2015

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 30, 2015

📌 Commit be38926 has been approved by Manishearth

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jun 30, 2015
@steveklabnik
Rollup merge of rust-lang#26651 - GuillaumeGomez:patch-2, r=Manishearth
65b5c15 
Part of rust-lang#24407.
cc @michaelsproul
r? @Manishearth
@steveklabnik steveklabnik mentioned this pull request Jun 30, 2015
Merged
bors added a commit that referenced this pull request Jun 30, 2015
@bors
Auto merge of #26696 - steveklabnik:rollup, r=steveklabnik
bf3c979 
- Successful merges: #26373, #26506, #26580, #26622, #26627, #26651, #26678, #26692
- Failed merges:
@bors bors merged commit be38926 into rust-lang:master Jul 1, 2015
@GuillaumeGomez GuillaumeGomez deleted the patch-2 branch July 1, 2015 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Manishearth Manishearth

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez @Manishearth @bors @nagisa