-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Change std::fs::File.set_len example #26972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Maybe it's best to even say in the doc that the file must be writable or have the appropriate permissions. Not sure how to word it so that it's correct for Windows. |
|
MSDN is not quite clear on what permission exactly is needed, but I assume https://msdn.microsoft.com/en-us/library/windows/desktop/aa365539%28v=vs.85%29.aspx |
The File object needs to be writable for the truncate to succeed.
|
Done. |
The File object needs to be writable for the set_len to succeed.
The File object needs to be writable for the set_len to succeed.