Skip to content

Add new error codes in librustc #28353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 2 commits into from
Sep 16, 2015
Merged

Add new error codes in librustc #28353

bors merged 2 commits into from
Sep 16, 2015

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Sep 11, 2015

r? @Manishearth

This is a work in progress.

nagisa
nagisa reviewed Sep 11, 2015
View reviewed changes
src/librustc/diagnostics.rs
Copy link
Member

@nagisa nagisa Sep 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t this be generalised to the E0452? There seems really little use to differentiate between an empty name and a malformed attribute.

Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Sep 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite hard to say... It can be generalised, but like this, we have a very precise error code for each.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Sep 14, 2015

@Manishearth: I'm done for librustc. Waiting for your review.

Manishearth
Manishearth reviewed Sep 14, 2015
View reviewed changes
src/librustc/diagnostics.rs Outdated
Copy link
Member

@Manishearth Manishearth Sep 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this sentence is trying to say here

Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Sep 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to replace the message from the compiler when something is unstable or deprecated with the tag #[deprecated] by some kind of compilation message. But it seems it's not possible. I hope I was more clear...

Copy link
Member

@Manishearth Manishearth Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"It is not possible to use stability attributes outside of the standard library. Also, for now, it is not possible to write deprecation messages either."

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Sep 16, 2015

Updated !

@Manishearth
Copy link
Member

Manishearth commented Sep 16, 2015

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 16, 2015

📌 Commit e6f6da1 has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Sep 16, 2015

⌛ Testing commit e6f6da1 with merge 8dfb890...

bors added a commit that referenced this pull request Sep 16, 2015
@bors
Auto merge of #28353 - GuillaumeGomez:error_codes, r=Manishearth
8dfb890 
r? @Manishearth 

This is a work in progress.
@bors
Copy link
Collaborator

bors commented Sep 16, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit e6f6da1 into rust-lang:master Sep 16, 2015
@bors bors mentioned this pull request Sep 16, 2015
Merged
@GuillaumeGomez GuillaumeGomez deleted the error_codes branch September 16, 2015 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Manishearth Manishearth

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez @Manishearth @bors @nagisa