Fix option link and anchor links.

[alexispurslane]

This was pointed out by @filsmick and @swatteau in #28412.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[alexispurslane]

r? @steveklabnik

[alexispurslane]

(Squashed the commits.)

[semmaz]

@steveklabnik @ChristopherDumas Shouldn't it be "fixed" the other way round, making rustdoc rendered id and href attributes of section identical to href rendered by github (discarding special chars)?

I'm willing to give it a try and see how many of breakage it will introduce to docs.

[steveklabnik]

@semmaz it would be nice if rustdoc were fixed to do that, but in the meantime, this is a nice, quick fix. With the release coming out soon, this can be backported, and we can fix the underlying issue For Real later, which will take more time. If you'd like to work on that, please do!

@ChristopherDumas you still have some LLVM changes in here :)

[steveklabnik]

oh, no, you fixed it. but it's still out of date for some reason, can you try to rebase please?

[alexispurslane]

Sure

[alexispurslane]

I rebased this.

[steveklabnik]

@bors: r+ rollup

[bors]

📌 Commit e66a1dc has been approved by steveklabnik

[bors]

⌛ Testing commit e66a1dc with merge 1fe126a...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt