Skip to content

Conversation

@alexispurslane
Copy link
Contributor

This was pointed out by @baskerville in #28460.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

r? @steveklabnik

@steveklabnik
Copy link
Contributor

In https://github.com/rust-lang/rust/pull/28441/files, @baskerville pointed out many more of these than just this one.

@baskerville, would you like to modify that PR to only have this change? I appreciate @ChristopherDumas tackling this, but also want to make sure that you get credit for work you had done, if that matters to you.

@baskerville
Copy link
Contributor

@steveklabnik should I create a new pull request?

@steveklabnik
Copy link
Contributor

superceded by #28466

Thanks again for all the quick PRs, @ChristopherDumas .

@alexispurslane alexispurslane deleted the off_by_one_memory branch September 17, 2015 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants