Rollup of 6 pull requests #28807
Merged
Rollup of 6 pull requests #28807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Oct 2, 2015
Manishearth
commented
- Successful merges: E0422 description. #28554, Don't crash on non-existent path in constant. #28686, Add link to Florian Wilkens's Bachelor's Thesis #28786, doc: fix swapped docs for intro_ptr and intro_raw of CString #28788, Add test for #25439 #28791, Rebase for gankro #28797
- Failed merges:
The behavior here isn't really ideal, but we can't really do much better given the current state of constant evaluation. Fixes rust-lang#28670, and probably a bunch of duplicates.
…=nikomatsakis The behavior here isn't really ideal, but we can't really do much better given the current state of constant evaluation. The changes to ExprUseVisitor are to avoid a compile error; apparently that bit of code is extremely sensitive to changes in other areas of the compiler. Fixes rust-lang#28670, and probably a bunch of duplicates.
This tiny PR just adds a link to Florian Wilkens's Bachelor's Thesis.
Please correct me if I confused something but the documentation for ```into_ptr``` and ```into_raw``` of ```CString``` seem to be swapped as the docs for ```into_ptr``` mentions ```into_raw``` and vice versa. Update: I actually meant ```into_ptr``` and ```into_raw``` NOT ```from_*```
…lexcrichton This is a rebase of rust-lang#27902, since @gankro is busy ❤️
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
@bors r+ p=5 |
Collaborator
|
📌 Commit e4797fa has been approved by |
Collaborator
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.