Fix LLVM assertion on out-of-bounds const slice index. #28841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turned up as part of rust-lang#3170. When constructing an `undef` value to return in the error case, we were trying to get the element type of the Rust-level value being indexed instead of the underlying array; when indexing a slice, that's not an array and the LLVM assertion failure reflects this. The regression test is a lightly altered copy of `const-array-oob.rs`.
Contributor
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Member
Collaborator
|
⌛ Testing commit fd07780 with merge 463d824... |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 7, 2015
This turned up as part of rust-lang#3170. When constructing an `undef` value to return in the error case, we were trying to get the element type of the Rust-level value being indexed instead of the underlying array; when indexing a slice, that's not an array and the LLVM assertion failure reflects this. The regression test is a lightly altered copy of `const-array-oob.rs`.
Collaborator
|
⛄ The build was interrupted to prioritize another pull request. |
Collaborator
|
⌛ Testing commit fd07780 with merge 28e2f5d... |
Collaborator
|
⛄ The build was interrupted to prioritize another pull request. |
Collaborator
bors
added a commit
that referenced
this pull request
Oct 7, 2015
This turned up as part of #3170. When constructing an `undef` value to return in the error case, we were trying to get the element type of the Rust-level value being indexed instead of the underlying array; when indexing a slice, that's not an array and the LLVM assertion failure reflects this. The regression test is a lightly altered copy of `const-array-oob.rs`.
Collaborator
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned up as part of #3170. When constructing an
undefvalue toreturn in the error case, we were trying to get the element type of the
Rust-level value being indexed instead of the underlying array; when
indexing a slice, that's not an array and the LLVM assertion failure
reflects this.
The regression test is a lightly altered copy of
const-array-oob.rs.