Skip to content

Conversation

@dcarral
Copy link
Contributor

@dcarral dcarral commented Oct 15, 2015

Regarding #29063 [Docs] Terminology inconsistency between 'iterator adapters' and 'iterator adaptors' :

This PR replaces 'iterator adapters' appearances (in TRPL book) to 'iterator adaptors', thus embracing the terminology used along the API docs and achieving consistency between both sources.

Regarding rust-lang#29063: Replace 'iterator adapters' appearances to
'iterator adaptors', thus embracing the terminology used along the
API docs and achieving consistency between both sources.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

cc @steveklabnik

I always forget what the right word is here...

@steveklabnik
Copy link
Contributor

Apparently both are basically valid in both American and British English, so, you really have to just pick one.

If we used "or" more, seems fine to stick with it. Thanks @dcarral !

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 15, 2015

📌 Commit 6bff154 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 15, 2015
…bnik

Regarding [rust-lang#29063 _[Docs] Terminology inconsistency between 'iterator adapters' and 'iterator adaptors'_](rust-lang#29063) :

This PR replaces 'iterator adapters' appearances (in TRPL book) to 'iterator adaptors', thus embracing the terminology used along the API docs and achieving consistency between both sources.
Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 15, 2015
…bnik

Regarding [rust-lang#29063 _[Docs] Terminology inconsistency between 'iterator adapters' and 'iterator adaptors'_](rust-lang#29063) :

This PR replaces 'iterator adapters' appearances (in TRPL book) to 'iterator adaptors', thus embracing the terminology used along the API docs and achieving consistency between both sources.
bors added a commit that referenced this pull request Oct 15, 2015
@bors bors merged commit 6bff154 into rust-lang:master Oct 15, 2015
@dcarral dcarral deleted the fix_issue_29063 branch October 23, 2015 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants