Don't ICE if the linker prints something non-UTF-8 #29134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The escaped form isn't pretty, but this should be a very rare error. Having a general binary-escaping string creation function might be a good idea, though. Closes rust-lang#29122
Contributor
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
Hmm, is there a reasonable way to write a regression test for this? maybe a My plan is to approve this PR, but open an issue elsewhere for the regression test |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit d12522c has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Oct 18, 2015
The escaped form isn't pretty, but this should be a very rare error. Having a general binary-escaping string creation function might be a good idea, though. Closes #29122
Contributor
Author
|
Oops. Yeah, I just forgot to write a regression test. I'll get that done tomorrow. |
Collaborator
wthrowe
added a commit
to wthrowe/rust
that referenced
this pull request
Oct 18, 2015
wthrowe
added a commit
to wthrowe/rust
that referenced
this pull request
Oct 22, 2015
wthrowe
added a commit
to wthrowe/rust
that referenced
this pull request
Oct 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The escaped form isn't pretty, but this should be a very rare error.
Having a general binary-escaping string creation function might be a
good idea, though.
Closes #29122