Stricter doctests for corelibs #29544
Conversation
Ryman
force-pushed
the
reduce_doc_warnings
branch
from
3d1a605 to
956986a
Compare
|
This looks great, thanks! I love the idea of making these more strict, I just didn't take the time to do it myself. I'm going to merge as-is. I'm in the middle of going through the whole stdlib docs anyway, so if I want to make changes, I will do so then. This looks great for now. And keeping the commits split per library seems fine as well. |
|
@bors: r+ rollup |
|
📌 Commit 956986a has been approved by |
|
(sorry for the long review delay, as well :/) |
…labnik Did this alphabetically, so I didn't see [how `std` was doing things](https://dxr.mozilla.org/rust/source/src/libstd/lib.rs#215) till I was nearly finished. If you prefer to add crate-level-whitelists like std instead of test-level, I can rebase with that strategy. A number of these commits can probably be dropped as the crates don't have much to test, and are deprecated. Let me know which if any to drop! (can also squash after review if desired) r? @steveklabnik
|
☔ The latest upstream changes (presumably #29546) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@Ryman you sent me a message on IRC, but you're not on now. Just a rebase is fine :) |
Ryman
force-pushed
the
reduce_doc_warnings
branch
from
956986a to
5ae1937
Compare
|
@steveklabnik rebased (and removed liblibc commit as it should be done on crates.io repo now)! |
|
@bors: r+ p=1 |
|
📌 Commit 5ae1937 has been approved by |
Did this alphabetically, so I didn't see [how `std` was doing things](https://dxr.mozilla.org/rust/source/src/libstd/lib.rs#215) till I was nearly finished. If you prefer to add crate-level-whitelists like std instead of test-level, I can rebase with that strategy. A number of these commits can probably be dropped as the crates don't have much to test, and are deprecated. Let me know which if any to drop! (can also squash after review if desired) r? @steveklabnik
|
(giving priority since this touches a lot of things) |
|
(but i guess the queue is already empty so) |
3 participants
Did this alphabetically, so I didn't see how
stdwas doing things till I was nearly finished. If you prefer to add crate-level-whitelists like std instead of test-level, I can rebase with that strategy.A number of these commits can probably be dropped as the crates don't have much to test, and are deprecated. Let me know which if any to drop! (can also squash after review if desired)
r? @steveklabnik