Split core::iter module implementation into parts #33079
Conversation
split iter.rs into a directory of (implementation private) modules. + mod Adaptor structs - Private fields need to be available both for them and Iterator + iterator (Iterator trait) + traits (FromIterator, traits but Iterator itself) + range (range related) + sources (Repeat, Once, Empty)
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I was looking for a good diff tool to display / review this with. No functional change (of course). Only edits are license headers and This git command makes it show a diff between iter.rs and each output file at least: |
|
Nice! Currently Other than that this basically all looks good to me! r=me with that minor change |
|
No diff is too big for you! I've moved the ESI impls now, that's a good thing to do anyway. @bors r=alexcrichton |
|
📌 Commit 1cd8d1e has been approved by |
|
⌛ Testing commit 1cd8d1e with merge 6307e2b... |
|
💔 Test failed - auto-win-gnu-64-nopt-t |
|
@bors retry |
|
⌛ Testing commit 1cd8d1e with merge d53909f... |
|
💔 Test failed - auto-win-msvc-32-opt |
|
@bors: retry On Thu, Apr 21, 2016 at 8:37 AM, bors notifications@github.com wrote:
|
|
💔 Test failed - auto-win-gnu-32-nopt-t |
|
@bors: retry On Thu, Apr 21, 2016 at 10:58 AM, bors notifications@github.com wrote:
|
Split core::iter module implementation into parts Split core::iter module implementation into parts split iter.rs into a directory of (implementation private) modules. + mod (adaptor structs whose private fields need to be available both for them and Iterator + iterator (Iterator trait) + traits (FromIterator, etc; all traits but Iterator itself) + range (range related) + sources (Repeat, Once, Empty)
|
💔 Test failed - auto-win-msvc-32-opt |
|
@bors: retry On Thu, Apr 21, 2016 at 6:11 PM, bors notifications@github.com wrote:
|
4 participants
Split core::iter module implementation into parts
split iter.rs into a directory of (implementation private) modules.