-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
add a test case for issue #32031 #34241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dsprenkels Can you add the email address you used in the commit to your github account? Otherwise the commits are not linked to your account. This is of course not necessary, let me know if it's intentional. |
src/test/codegen/issue-32031.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance this could also check the return type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I meant, btw, is that the full signature is define float @add_newtype_f32(float, float) - and if you include all of it, you also ensure the return type is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, check. I'll fix this accordingly.
5645c76 to
5f49e85
Compare
|
Yup, this was indeed not intentional. Thanks for the heads-up! I also added a check for the return type. |
5f49e85 to
a30130d
Compare
src/test/codegen/issue-32031.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not double?
a30130d to
e196021
Compare
e196021 to
688840f
Compare
|
@bors r+ Thanks! |
|
📌 Commit 688840f has been approved by |
I propose a test case to finish the fix for issue #32031. Please review this commit thoroughly, as I have never written a codegen test before.
r? @eddyb