convert AdtDef::destructor to on-demand #40178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the Cell from AdtDef. Also, moving destructor validity checking to on-demand (forced during item-type checking) ensures that invalid destructors can't cause ICEs. Fixes rust-lang#38868. Fixes rust-lang#40132.
Member
|
@bors r+ |
Collaborator
|
📌 Commit e294fd5 has been approved by |
Collaborator
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
bjorn3
reviewed
Mar 9, 2017
| /// invoked even when there are lifetimes in the type-structure of | ||
| /// `adt` that do not strictly outlive the adt value itself. | ||
| /// (This allows programs to make cyclic structures without | ||
| /// resorting to unasfe means; see RFCs 769 and 1238). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
CellfromAdtDef. Also, moving destructor validitychecking to on-demand (forced during item-type checking) ensures that
invalid destructors can't cause ICEs.
Fixes #38868.
Fixes #40132.
r? @eddyb