E05XX odyssey #43726
E05XX odyssey #43726
Conversation
GuillaumeGomez
left a comment
GuillaumeGomez
left a comment
There was a problem hiding this comment.
A few things to change but globally it's good.
src/librustc_passes/diagnostics.rs
Outdated
There was a problem hiding this comment.
A long error explanation is supposed to start by a short summary of the error. The error explanation comes just after the erroneous code example and just before the fix.
src/libsyntax/diagnostic_list.rs
Outdated
There was a problem hiding this comment.
The explanation is supposed to be after the erroneous code example.
src/libsyntax/diagnostic_list.rs
Outdated
There was a problem hiding this comment.
@GuillaumeGomez Just writing ignore without explanation will cause tidy failure. --explain will strip them out though.
src/libsyntax/diagnostic_list.rs
Outdated
There was a problem hiding this comment.
Seems a bit complicated when formulated this way.
src/libsyntax/feature_gate.rs
Outdated
arielb1
added
the
S-waiting-on-author
It's more pleasing to use the inner-attribute syntax (`#!` rather than `#`) in the error message, as that is how `feature` attributes in particular will be declared (as they apply to the entire crate).
zackmdavis
force-pushed
the
extended_information_summer_block_party
branch
from
6e43cfd to
116bf07
Compare
|
(updated) |
|
Thanks! @bors: r+ |
|
📌 Commit 116bf07 has been approved by |
…arty, r=GuillaumeGomez E05XX odyssey chipping away at the surface exposed by #43709 r? @GuillaumeGomez
|
☀️ Test successful - status-appveyor, status-travis |
5 participants
chipping away at the surface exposed by #43709
r? @GuillaumeGomez