Skip to content

make erase_regions_ty query anonymous#45364

Merged
bors merged 1 commit intorust-lang:masterfrom
nikomatsakis:issue-44137-anon
Oct 21, 2017
Merged

make erase_regions_ty query anonymous#45364
bors merged 1 commit intorust-lang:masterfrom
nikomatsakis:issue-44137-anon

Conversation

@nikomatsakis
Copy link
Contributor

@nikomatsakis nikomatsakis commented Oct 18, 2017

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2017
@michaelwoerister
Copy link
Member

michaelwoerister commented Oct 18, 2017

@bors try

@bors
Copy link
Collaborator

bors commented Oct 18, 2017

⌛ Trying commit b5e2451 with merge afa558b...

bors added a commit that referenced this pull request Oct 18, 2017
@bors
Auto merge of #45364 - nikomatsakis:issue-44137-anon, r=<try>
afa558b 
make `erase_regions_ty` query anonymous

r? @michaelwoerister
@bors
Copy link
Collaborator

bors commented Oct 18, 2017

☀️ Test successful - status-travis
State: approved= try=True

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Oct 18, 2017

Presuming you wanted a perf build: http://perf.rust-lang.org/compare.html?start=7a4f39453cfbeab1c2220331f2eae8938165c964&end=afa558bf87d8910d28d3d52a4aa1232bd7fae2bc&stat=instructions%3Au.

@nikomatsakis
Copy link
Contributor Author

nikomatsakis commented Oct 18, 2017

Doesn't look especially significant, though it does help a few tests.

@michaelwoerister
Copy link
Member

michaelwoerister commented Oct 19, 2017

Thanks, @Mark-Simulacrum! That's indeed what I wanted.

@nikomatsakis I think those are pretty good improvements for a one line change :)

Could we even go further and not even allocate a node if it is anonymous and has no inputs?

@michaelwoerister
Copy link
Member

michaelwoerister commented Oct 20, 2017

There might be room for further improvement here by not even allocating a DepNode in cases like this but that would need a slightly bigger change. Let's not wait for that.

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 20, 2017

📌 Commit b5e2451 has been approved by michaelwoerister

@michaelwoerister
Copy link
Member

michaelwoerister commented Oct 20, 2017

I opened #45408 regarding further optimization.

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2017
@bors
Copy link
Collaborator

bors commented Oct 21, 2017

⌛ Testing commit b5e2451 with merge 6a136f6...

bors added a commit that referenced this pull request Oct 21, 2017
@bors
Auto merge of #45364 - nikomatsakis:issue-44137-anon, r=michaelwoerister
6a136f6 
make `erase_regions_ty` query anonymous

r? @michaelwoerister
@bors
Copy link
Collaborator

bors commented Oct 21, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing 6a136f6 to master...

@bors bors merged commit b5e2451 into rust-lang:master Oct 21, 2017
@Zalathar Zalathar mentioned this pull request Feb 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@michaelwoerister michaelwoerister

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nikomatsakis @michaelwoerister @bors @Mark-Simulacrum @kennytm