rustc: Add some more compatibility with AVX-512 #45528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
I'm holding on these ABI changes until @eddyb's PR lands |
Member
Author
|
Sure thing! |
kennytm
added
the
S-waiting-on-author
Member
|
(meta) I think there should be an S-waiting-on-another-PR (#45225?) tag 😛 |
gnzlbg
reviewed
Nov 6, 2017
Contributor
gnzlbg
left a comment
gnzlbg
left a comment
There was a problem hiding this comment.
c&p bug, otherwise looks great
src/librustc_trans/llvm_util.rs
Outdated
Contributor
There was a problem hiding this comment.
avx512vbmi is repeated twice here, and avx512vpopcntdq is missing
Member
Author
kennytm
added
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #45761) made this pull request unmergeable. Please resolve the merge conflicts. |
* Increase the maximum vector size in the ABI calculations to ensure that AVX-512 operands are immediates. * Add a few more `target_feature` matchings for AVX-512 features
Member
Author
|
ping @arielb1, thoughts on my previous comment? |
Collaborator
|
📌 Commit d3563bb has been approved by |
kennytm
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Nov 16, 2017
rustc: Add some more compatibility with AVX-512 * Increase the maximum vector size in the ABI calculations to ensure that AVX-512 operands are immediates. * Add a few more `target_feature` matchings for AVX-512 features
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVX-512 operands are immediates.
target_featurematchings for AVX-512 features