Skip to content

auto: Add clang 4.2 to supported versions (that what Apple calls 3.2svn) r=graydon#4753

Closed
labria wants to merge 1 commit into
rust-lang:masterfrom
labria:master
Closed

auto: Add clang 4.2 to supported versions (that what Apple calls 3.2svn) r=graydon#4753
labria wants to merge 1 commit into
rust-lang:masterfrom
labria:master

Conversation

@labria
Copy link
Copy Markdown
Contributor

@labria labria commented Feb 1, 2013

Apple released a new XCode version with clang 3.2svn, but called it 4.2, thus breaking ./configure.

@labria
Copy link
Copy Markdown
Contributor Author

labria commented Feb 3, 2013

When does auto get merged into master? I need to change this pull request to match the changes.

@graydon
Copy link
Copy Markdown
Contributor

graydon commented Feb 4, 2013

This pull req was made against master; as mentioned in the contributing file ( https://github.com/mozilla/rust/blob/master/CONTRIBUTING.md ) we need pull requests to target the incoming branch, at least presently. We hope to be away from this requirement soon. Apologies. I'll fix this up in this case, it's small enough not to be worth fussing over.

Thanks for your contribution!

@graydon
Copy link
Copy Markdown
Contributor

graydon commented Feb 4, 2013

Opened correctly targeted pull #4787 , closing this one.

@graydon graydon closed this Feb 4, 2013
@labria
Copy link
Copy Markdown
Contributor Author

labria commented Feb 4, 2013

Oh, ok. Sorry I missed the file when I created the pull request.

vertexclique pushed a commit to vertexclique/rust that referenced this pull request Feb 11, 2014
This is just a retargeting of rust-lang#4753 against incoming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants