move Cargo.toml to live alongside x.py #48236
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors: r+ I think there's another PR to do this already as well though? It may need rebasing maybe |
Collaborator
|
📌 Commit 882ff7d has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 16, 2018
…o-toml, r=alexcrichton move Cargo.toml to live alongside x.py This makes it so that, when you `./x.py`, you get errors relative to the location of `x.py`. I would also be fine with moving `x.py` into `src`, if that is deemed preferable. (Is this a good idea?) One of the other seems to make sense to me, but I'm curious what others think. =) r? @alexcrichton cc @pnkfelix (I suppose one could also run `../x.py` from the `src` directory, but then that creates `src/build` directory, which I don't particularly like.) (Also, this is only minimally tested.)
Contributor
|
For the record, I believe the other PR that @alexcrichton is referring to is PR #47731 |
Contributor
|
(which means ... is this likely to not pass bors unless it incorporates the fixups that have been incrementally added to #47731 ? hmm...) |
Contributor
Member
|
Yes, I'm going to just close this in favor of #47731. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that, when you
./x.py, you get errors relative to the location ofx.py. I would also be fine with movingx.pyintosrc, if that is deemed preferable. (Is this a good idea?) One or the other seems to make sense to me, but I'm curious what others think. =)r? @alexcrichton
cc @pnkfelix
(I suppose one could also run
../x.pyfrom thesrcdirectory, but then that createssrc/builddirectory, which I don't particularly like.)(Also, this is only minimally tested.)