Add check for 'file' command which is necessary for 32-bit userspace detection. #5837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm not sure if it matters anymore with our new build automation, can you re-submit this with |
bors
added a commit
that referenced
this pull request
Apr 12, 2013
Without 'file' it assumes a 32 bit userspace even with a 64 bit kernel, which is incorrect in most cases.
Contributor
|
Actually, don't bother doing that; I think the build automation bot will do the right thing. Thanks! |
flip1995
added a commit
to flip1995/rust
that referenced
this pull request
Aug 11, 2020
needless_collect: catch x: Vec<_> = iter.collect(); x.into_iter() ... changelog: Expand the needless_collect lint as suggested in rust-lang#5627 (WIP). This PR is WIP because I can't figure out how to make the multi-part suggestion include its changes in the source code (the fixed is identical to the source, despite the lint making suggestions). Aside from that one issue, I think this should be good.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 11, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#5837 (needless_collect: catch x: Vec<_> = iter.collect(); x.into_iter() ...) - rust-lang#5846 (Handle mapping to Option in `map_flatten` lint) - rust-lang#5848 (Add derive_ord_xor_partial_ord lint) - rust-lang#5852 (Add lint for duplicate methods of trait bounds) - rust-lang#5856 (Remove old Symbol reexport) Failed merges: r? @ghost changelog: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without 'file' it assumes a 32 bit userspace even with a 64 bit kernel, which is incorrect in most cases.