Rollup of 4 pull requests #64526
Merged
Rollup of 4 pull requests #64526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes some extra blank lines and makes some minor tweaks to the wording.
`AdtDef` is an algebraic data type, not abstract data type r? @varkor
update Miri Fixes rust-lang#64363 r? @alexcrichton for the Cargo.toml changes: with byteorder 1.3, the `i128` feature is a NOP, so we can remove it everywhere and then get rid of this crate in the workspace-hack.
…r=Centril Make some adjustments to the documentation for `std::convert::identity` Fixes some extra blank lines and makes some minor tweaks to the wording.
…r-proj-slice, r=oli-obk Use while let slice_pattern instead of carrying an index around r? @oli-obk
Contributor
Author
|
@bors r+ p=4 rollup=never |
Collaborator
|
📌 Commit 1376ccd has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Sep 16, 2019
Rollup of 4 pull requests Successful merges: - #64357 (`AdtDef` is an algebraic data type, not abstract data type) - #64485 (update Miri) - #64509 (Make some adjustments to the documentation for `std::convert::identity`) - #64518 (Use while let slice_pattern instead of carrying an index around) Failed merges: r? @ghost
Collaborator
|
☀️ Test successful - checks-azure |
Contributor
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Sep 17, 2019
Tested on commit rust-lang/rust@7ac21e7. Direct link to PR: <rust-lang/rust#64526> 🎉 miri on windows: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra). 🎉 miri on linux: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
AdtDefis an algebraic data type, not abstract data type #64357 (AdtDefis an algebraic data type, not abstract data type)std::convert::identity#64509 (Make some adjustments to the documentation forstd::convert::identity)Failed merges:
r? @ghost