rustc: Change ty::get_impl_traits to return an option instead of a vec #6543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impls can implement either zero or one traits; this has been true more or less since we removed classes. So I got rid of the comments saying "we should support multiple traits" and changed the code to make it clear that we don't. This is just cleanup, and doesn't break any existing tests.
bors
added a commit
that referenced
this pull request
May 16, 2013
r? @nikomatsakis Impls can implement either zero or one traits; this has been true more or less since we removed classes. So I got rid of the comments saying "we should support multiple traits" and changed the code to make it clear that we don't. This is just cleanup, and doesn't break any existing tests.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 8, 2021
New Lint: needless_for_each resolves: rust-lang#6543 changelog: Added pedantic lint: `needless_for_each`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis Impls can implement either zero or one traits; this has been true
more or less since we removed classes. So I got rid of the comments
saying "we should support multiple traits" and changed the code to
make it clear that we don't. This is just cleanup, and doesn't break
any existing tests.