driver: perform stripping before and after macro expansion. #7297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows macros to both be conditionally defined, and expand to items with #[cfg]'s.
bors
added a commit
that referenced
this pull request
Jun 26, 2013
This allows macros to both be conditionally defined, and expand to items with #[cfg]'s. This seems to have a performance improvement, e.g. for `std`: ``` # Before time: 1.660 s expansion time: 0.125 s configuration # After time: 0.080 s configuration 1 time: 1.127 s expansion time: 0.132 s configuration 2 ``` And for `extra`: ``` # Before time: 0.593 s expansion time: 0.062 s configuration # After time: 0.047 s configuration 1 time: 0.147 s expansion time: 0.058 s configuration 2 ``` (This seems a little peculiar, but it is possibly because the expansion AST traversal is very slow, so removing as much as possible as early as possible has big benefits.)
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 3, 2021
Remove util/cov.sh script This script hasn't been working and wasn't used for years. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows macros to both be conditionally defined, and expand
to items with #[cfg]'s.
This seems to have a performance improvement, e.g. for
std:And for
extra:(This seems a little peculiar, but it is possibly because the expansion AST traversal is very slow, so removing as much as possible as early as possible has big benefits.)