Skip to content

Conversation

@csmoe
Copy link
Contributor

@csmoe csmoe commented Aug 27, 2020

Closes #75977
But I'm surprised that x.py test --stage 1 and CI didn't catch this with existing testcase.
r? @estebank

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2020
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 27, 2020

📌 Commit b71c8b6 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2020
@matthiaskrgr
Copy link
Member

@csmoe it seems the error only happens when using the 2015 edition, maybe that is the cause.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Aug 27, 2020
Should not apply field accessing on enum

Closes rust-lang#75977
But I'm surprised that `x.py test --stage 1` and CI didn't catch this with existing testcase.
r? @estebank
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Aug 29, 2020
Should not apply field accessing on enum

Closes rust-lang#75977
But I'm surprised that `x.py test --stage 1` and CI didn't catch this with existing testcase.
r? @estebank
@bors
Copy link
Collaborator

bors commented Aug 29, 2020

⌛ Testing commit b71c8b6 with merge 65d071e...

@bors
Copy link
Collaborator

bors commented Aug 29, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: estebank
Pushing 65d071e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 29, 2020
@bors bors merged commit 65d071e into rust-lang:master Aug 29, 2020
@cuviper cuviper added this to the 1.48.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE assertion failed: self.is_struct() || self.is_union()

6 participants