Skip to content

Conversation

@sp3d
Copy link
Contributor

@sp3d sp3d commented Jul 15, 2013

This should be pretty self-explanatory. The most important component is region/lifetime annotation highlighting, as previously they were interpreted as character literals and would ruin the rest of the line. The attribute regex is fairly crude, but it gets the job done and there's not much within attributes that would benefit from individual highlighting, so fancier handling didn't seem worth the trouble.

The ident regex was copied from the vim highlighter.

bors added a commit that referenced this pull request Jul 15, 2013
This should be pretty self-explanatory. The most important component is region/lifetime annotation highlighting, as previously they were interpreted as character literals and would ruin the rest of the line. The attribute regex is fairly crude, but it gets the job done and there's not much within attributes that would benefit from individual highlighting, so fancier handling didn't seem worth the trouble.

The ident regex was copied from the vim highlighter.
@bors bors closed this Jul 15, 2013
@bors bors merged commit 9adad22 into rust-lang:master Jul 15, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 21, 2021
Fix FP in external macros for `mut_mut` lint

Fix FP in `mut_mut` lint when type is defined in external macros.

fixes: rust-lang#6922

changelog: [`mut_mut`] Fix FP when type is defined in external macros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants