Skip to content

TryReserveErrorKind tests and inline #87843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 2 commits into from
Aug 12, 2021
Merged

TryReserveErrorKind tests and inline #87843

bors merged 2 commits into from
Aug 12, 2021

Conversation

@kornelski
Copy link
Contributor

@kornelski kornelski commented Aug 7, 2021

A small follow-up to #87408

@rust-highfive
Copy link
Contributor

rust-highfive commented Aug 7, 2021

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2021
@kornelski kornelski mentioned this pull request Aug 7, 2021
Merged
@the8472
Copy link
Member

the8472 commented Aug 7, 2021

I didn't explicitly mention it, the kind() method probably needs an inline too, for the same reason.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@kornelski
Copy link
Contributor Author

kornelski commented Aug 7, 2021

kind already has inline

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@m-ou-se
Copy link
Member

m-ou-se commented Aug 11, 2021

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 11, 2021

📌 Commit 7dca8eb has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2021
@m-ou-se m-ou-se assigned m-ou-se and unassigned joshtriplett Aug 11, 2021
@m-ou-se m-ou-se added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 11, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Aug 12, 2021

@bors rollup=never

(Because of #87408 (comment))

@bors
Copy link
Collaborator

bors commented Aug 12, 2021

⌛ Testing commit 7dca8eb with merge 25d3e14...

@bors
Copy link
Collaborator

bors commented Aug 12, 2021

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 25d3e14 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 12, 2021
@bors bors merged commit 25d3e14 into rust-lang:master Aug 12, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 12, 2021
@kornelski kornelski deleted the try_reserve branch November 6, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@m-ou-se m-ou-se

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

8 participants

@kornelski @rust-highfive @the8472 @rust-log-analyzer @m-ou-se @bors @joshtriplett @rustbot