Skip to content

Make thiscall abi on unsupported platforms a hard error #90241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Oct 26, 2021
Merged

Make thiscall abi on unsupported platforms a hard error #90241

bors merged 1 commit into from
Oct 26, 2021

Conversation

@beepster4096
Copy link
Contributor

@beepster4096 beepster4096 commented Oct 24, 2021

As suggested in #42202 (comment), this PR makes use of the thiscall abi on unsupported a hard error instead of a lint.

@rust-highfive
Copy link
Contributor

rust-highfive commented Oct 24, 2021

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

rust-highfive commented Oct 24, 2021

⚠️ Warning ⚠️

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov
Copy link
Contributor

petrochenkov commented Oct 24, 2021

r? @petrochenkov

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov
Copy link
Contributor

petrochenkov commented Oct 24, 2021 •
edited
Loading

The is_like_windows flag is irrelevant to supporting ABI in codegen (it's a compatibility hack), Thiscall should be supported if self.arch == "x86" and not supported otherwise.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2021
@petrochenkov
Copy link
Contributor

petrochenkov commented Oct 25, 2021

r=me after squashing commits.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2021
@petrochenkov petrochenkov mentioned this pull request Oct 25, 2021
Closed
@beepster4096 beepster4096 force-pushed the thiscall_lint_upgrade branch from 1c43a2b to a46daf0 Compare October 25, 2021 21:56
@beepster4096
Copy link
Contributor Author

beepster4096 commented Oct 25, 2021

Commits have been squashed.

@petrochenkov
Copy link
Contributor

petrochenkov commented Oct 25, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 25, 2021

📌 Commit a46daf0 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 26, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2021
@bors
Auto merge of rust-lang#90299 - matthiaskrgr:rollup-n77ntld, r=matthi…
1b61b1b 
…askrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#90181 (fix(rustc_typeck): report function argument errors on matching type)
 - rust-lang#90241 (Make thiscall abi on unsupported platforms a hard error)
 - rust-lang#90294 (Update books)
 - rust-lang#90295 (Update cargo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fc8df9b into rust-lang:master Oct 26, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 26, 2021
@bors
Copy link
Collaborator

bors commented Oct 26, 2021

⌛ Testing commit a46daf0 with merge 1b61b1b...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.58.0

Development

Successfully merging this pull request may close these issues.

7 participants

@beepster4096 @rust-highfive @rust-log-analyzer @petrochenkov @bors @oli-obk @rustbot