Issue #6580: Change default lint output format. #9778
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since lint check attributes are the preferred way of selectively enabling/disabling lint checks, the output format of a failed default check has been changed to reflect that. When lint checks are being explicitly set by a command-line flag or an attribute, the behavior is unchanged, so that the user can quickly pinpoint the source.
Author
Member
|
Looks good to me, thanks! Could you also add a test to make sure that functionality like this doesn't regress? It would involve adding a test file to There should be lots of examples in adjacent files (although ignore the ones with Also, could you put the words |
Member
|
Closing in favor of #9782 |
bors
added a commit
that referenced
this pull request
Oct 9, 2013
Since lint check attributes are the preferred way of selectively enabling/disabling lint checks, the output format of a failed default check has been changed to reflect that. When lint checks are being explicitly set by a command-line flag or an attribute, the behavior is unchanged, so that the user can quickly pinpoint the source. Supersedes the patch suggested in #9778 Closes #6580
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since lint check attributes are the preferred way of selectively
enabling/disabling lint checks, the output format of a failed
default check has been changed to reflect that.
When lint checks are being explicitly set by a command-line flag
or an attribute, the behavior is unchanged, so that the user can
quickly pinpoint the source.