Skip to content

Fix example which wrongly implied that the upper bound of edition ranges was inclusive #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fmease merged 1 commit into from
Dec 2, 2025
Merged

Fix example which wrongly implied that the upper bound of edition ranges was inclusive #2669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/tests/directives.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,9 @@ This affects which edition is used by `./x test` to run the test.
For example:

- A test with the `//@ edition: 2018` directive will only run under the 2018 edition.
- A test with the `//@ edition: 2015..2021` directive can be run under the 2015, 2018, and 2021 editions.
- A test with the `//@ edition: 2015..2021` directive can be run under the 2015 and the 2018 edition,
so the upper bound is exclusive just like in Rust
(note that there's no equivalent to Rust's `..=` where the upper bound is inclusive).
However, CI will only run the test with the lowest edition in the range (which is 2015 in this example).
- A test with the `//@ edition: 2018..` directive will run under 2018 edition or greater.
However, CI will only run the test with the lowest edition in the range (which is 2018 in this example).
Expand Down
Loading