Make test suite formatting remark more precise #2685
Merged
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Member
Author
|
cc @ZuseZ4 does this seem clearer to you? |
jieyouxu
commented
Dec 12, 2025
Comment on lines
+30
to
+32
| > Consult the `ignore` entries in | ||
| > <https://github.com/rust-lang/rust/blob/main/rustfmt.toml> for which test | ||
| > files are not formatted. |
Member
Author
There was a problem hiding this comment.
Remark: Not listing any test suites here because rustfmt.toml is the source of truth, specific tests can also get ignored, not just on a test suite granularity.
Member
|
I have a local, not checked in, GPU test that keeps triggering the fmt check, so I would have been a bit confused by docs saying that |
Member
Author
|
Don't recall which test suite that would fall under, but yes, at times you may have to add specific tests if it doesn't make sense to be formatted. |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? BoxyUwU