-
Notifications
You must be signed in to change notification settings - Fork 576
Updated dates #2796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Updated dates #2796
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| # Updating LLVM | ||
|
|
||
| <!-- date-check: Aug 2024 --> | ||
| Rust supports building against multiple LLVM versions: | ||
|
|
||
| * Tip-of-tree for the current LLVM development branch is usually supported within a few days. | ||
|
|
@@ -91,7 +90,6 @@ An example PR: [#59089](https://github.com/rust-lang/rust/pull/59089) | |
|
|
||
| ## New LLVM Release Updates | ||
|
|
||
| <!-- date-check: Jul 2023 --> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto, I think we can remove this. |
||
|
|
||
| Unlike bugfixes, | ||
| updating to a new release of LLVM typically requires a lot more work. | ||
|
|
@@ -172,12 +170,14 @@ so let's go through each in detail. | |
| You'll change at least | ||
| `src/llvm-project` and will likely also change [`llvm-wrapper`] as well. | ||
|
|
||
| <!-- date-check: mar 2025 --> | ||
| <!-- date-check: March 2026 --> | ||
| > For prior art, here are some previous LLVM updates: | ||
| > - [LLVM 17](https://github.com/rust-lang/rust/pull/115959) | ||
| > - [LLVM 18](https://github.com/rust-lang/rust/pull/120055) | ||
| > - [LLVM 19](https://github.com/rust-lang/rust/pull/127513) | ||
| > - [LLVM 20](https://github.com/rust-lang/rust/pull/135763) | ||
| > - [LLVM 21](https://github.com/rust-lang/rust/pull/143684) | ||
| > - [LLVM 22](https://github.com/rust-lang/rust/pull/150722) | ||
|
|
||
| Note that sometimes it's easiest to land [`llvm-wrapper`] compatibility as a PR | ||
| before actually updating `src/llvm-project`. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,7 @@ which boils down to a static with type [`&rustc_lint_defs::Lint`] | |
| as the macro is somewhat unwieldy to add new fields to, | ||
| like all macros). | ||
|
|
||
| As of <!-- date-check --> Aug 2022, | ||
| As of <!-- date-check --> March 2026, | ||
| we lint against direct declarations without the use of the macro. | ||
|
Comment on lines
-24
to
25
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. have you verified this is still true?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jyn514 (https://github.com/rust-lang/rust/blob/main/compiler/rustc_lint/src/lib.rs) i checked the above lib.rs looks like we are still using LINT_PASS_IMPL_WITHOUT_MACRO so i guess this is still true because this will act as global identifier. Any thoughts ? |
||
|
|
||
| Lint declarations don't carry any "state" - they are merely global identifiers | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this date-check is left over from when this used to hard-code LLVM versions. There's nothing here anymore that's version specific so I think we can just remove this date-check altogether rather than updating it.