Clean up and reorganize traits chapter #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oh I should note that all I am really doing is reorganizing the |
mark-i-m
changed the title
Contributor
Author
|
This might need some iteration to fix all the TODOs, but overall, I think it looks reasonable. |
mark-i-m
added
S-waiting-on-review
Contributor
Author
|
Blocked on #45 because I linked to ./param_env.html |
nikomatsakis
approved these changes
Feb 24, 2018
Contributor
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
This all seems good. I am thinking about rewriting a new chapter where I describe the (WIP) new architecture I have in mind to develop w/ traits team, which can then also serve as a place for us to collaborate on it.
Contributor
Author
|
Did you have any comments on the TODOs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nikomatsakis There are a bunch of TODOs scattered throughout that denote things about which I am not sure. I would appreciate some nudges of guidance on those points (and anything else you see) 😄
cc #6