Skip to content

Conversation

@ehuss
Copy link
Contributor

@ehuss ehuss commented Feb 23, 2018

CC #10

@mark-i-m mark-i-m self-requested a review February 23, 2018 18:27
@mark-i-m
Copy link
Contributor

I saw the TODOs. Do you mean for this to be WIP?

@mark-i-m mark-i-m added the S-waiting-on-author Status: this PR is waiting for additional action by the OP label Feb 23, 2018
@ehuss
Copy link
Contributor Author

ehuss commented Feb 23, 2018

I saw the TODOs. Do you mean for this to be WIP?

Not exactly. I wanted to block out where some of the rest of #10 could be filled out. I'm going to start looking into the infrastructure more to maybe fill out that section in a separate PR, but if someone else more knowledgeable gets to it, that would be great! As for Crater, I think someone else who actually uses it will need to fill it out.

@mark-i-m
Copy link
Contributor

@ehuss Sounds good! Thanks for the PR :)

@mark-i-m mark-i-m merged commit bfcdce6 into rust-lang:master Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: this PR is waiting for additional action by the OP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants