Reorganize the guide #651
Merged
Reorganize the guide #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@mark-i-m in my opinion this looks much better and makes way more sense :). |
spastorino
previously approved these changes
Apr 1, 2020
chrissimpkins
previously approved these changes
Apr 1, 2020
Contributor
chrissimpkins
left a comment
chrissimpkins
left a comment
There was a problem hiding this comment.
This looks great Mark!
Contributor
|
I really like the new intro paragraphs. +1! |
mark-i-m
dismissed stale reviews from chrissimpkins, JohnTitor, and spastorino
via
01f35c7
This was referenced Apr 1, 2020
Closed
JohnTitor
previously approved these changes
Apr 2, 2020
tshepang
previously requested changes
Apr 2, 2020
Centril
reviewed
Apr 2, 2020
chrissimpkins
previously approved these changes
Apr 3, 2020
Contributor
Author
|
Ok, I have pushed the following changes:
|
Contributor
Author
|
CI is finally green 💚 |
tshepang
reviewed
Apr 4, 2020
tshepang
reviewed
Apr 4, 2020
tshepang
reviewed
Apr 4, 2020
Contributor
Author
|
Thanks all! I think this is ready for a final review? |
Co-Authored-By: Chris Simpkins <git.simpkins@gmail.com>
Contributor
Author
|
CI is green again |
spastorino
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @rust-lang/wg-learning
Feedback appreciated :)