Use proc macro to define Config#3873
Closed
topecongiro wants to merge 11 commits intorust-lang:masterfrom
Closed
Conversation
| impl std::fmt::Display for ConfigError { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> { | ||
| match self { | ||
| ConfigError::UnstableConfigOption(unstables) => { |
Contributor
Author
There was a problem hiding this comment.
Unfortunately no, IIRC the issue is that we are parsing the same rustfmt.toml and emitting errors multiple times.
| // emit mode is always Stdout for Stdin. | ||
| config.set().emit_mode(EmitMode::Stdout); | ||
| config.set().verbose(Verbosity::Quiet); | ||
| config.set_emit_mode(EmitMode::Stdout); |
Member
There was a problem hiding this comment.
👍 definitely a friendly interface on getters/setters
To be honest, I am not sure if this is correct :(
These are now hidden from users
18b683a to
0474e1b
Compare
Contributor
Author
|
I will try this again after 2.0 release 🤷♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a proc macro for defining
Configstruct, which replaces the currentdefine_configmacro.The ultimate goal is to define the config like the following:
and let the config proc macro generate Configurations.md and test code under test/source/configs/ and tests/target/configs/. This PR is the first step toward the goal.
Other minor benefits include the following:
Since the
Configis part of the public API of rustfmt-as-a-lib, and this PR changes its interface, we should merge this as a part of the preparation for 2.0 release. I am creating a PR at the moment, however, for early feedback.