chore(rustfmt): remove executable path from usage string #5216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for another PR! The proposed changes look good to me. One minor ask: If this is the desired usage text for rustfmt I think it would be nice to have a test for it. Would you mind including a test for the usage text in |
Contributor
Author
|
@ytmimi added test for usage text |
ytmimi
reviewed
Feb 4, 2022
ytmimi
reviewed
Feb 4, 2022
Contributor
|
Thanks again for this PR! The changes look good to me, and I'm happy to move forward with them! |
ytmimi
approved these changes
Feb 4, 2022
calebcartwright
approved these changes
Feb 11, 2022
Member
calebcartwright
left a comment
calebcartwright
left a comment
There was a problem hiding this comment.
LGTM too! Thanks for the PR @tharun208 and @ytmimi for reviewing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
rustfmtexecutable path from usage string.Fixes #5214