`--no-modify-path` option for `rustup self uninstall`

[cyqsimon]

Problem you are trying to solve

My dotfiles are carefully tracked and managed by chezmoi. It would be nice if there's a way to tell rustup not to mess with it during uninstall, much like the option during install.

Solution you'd like

Add a --no-modify-path option for rustup self uninstall.

Notes

Seems like a rather simple addition. I can submit a PR.

I'm also open to naming the option something else. Bikeshedding welcomed.

[rami3l]

@cyqsimon Hi, thanks for filing this issue!

I use chezmoi personally as well. Which part of the installation experience would require saving a rustup-managed file in it? Wouldn't chezmoi apply suffice if that's really desired?

Many thanks in advance 🙏

[cyqsimon]

Which part of the installation experience would require saving a rustup-managed file in it?

Sorry for the lack of clarity; was in a rush. I use bash, so ~/.bashrc.

bash-5.1# cat .bashrc
if [ -f "$HOME/.cargo/env" ]; then
    . "$HOME/.cargo/env"
fi
bash-5.1# rustup self uninstall


Thanks for hacking in Rust!

This will uninstall all Rust toolchains and data, and remove
$HOME/.cargo/bin from your PATH environment variable.

Continue? (y/N) y

info: removing rustup home
info: removing cargo home
info: removing rustup binaries
info: rustup is uninstalled
bash-5.1# cat .bashrc
if [ -f "$HOME/.cargo/env" ]; then
    fi

As you can see I already have the conditional set up, so I really don't need rustup messing with it in any way. Currently there's no option that forgoes that.

Wouldn't chezmoi apply suffice if that's really desired?

Yeah it would. But it's an additional thing I would have to think about. And to be safe I'm not overriding any other unrelated temporary changes, I would have to chezmoi diff first. It's just an unnecessary headache.

[rami3l]

@cyqsimon I see. Thanks for your explanation, and in that case, I accept your proposal.

Would you be so kind as to propose a PR? Many thanks again 🙏